Page tree
Skip to end of metadata
Go to start of metadata

Implemented in 5.4.3

Part of magnolia-resources-2.4.2

In the process of the phase out of the in-place templating app due to templates now being loaded through the new resources mechanism, we gathered some information about the current state of in-place templating.

The underlying issue is  MGNLRES-179 - Getting issue details... STATUS

The migration process (including template comparison before failing)

  • We do not migrate versions
  • When end is reached without any errors, additional tasks can be executed (such as removing app launcher configuration)

(start)->(check enabled property of template)-><enabledResult>[true]->(check autoImport property of template)-><autoImportResult>[true]->(check ResourceOrigin for same template)-><resourceOriginResult>[false]->(Migrate template),<autoImportResult>[false]->(check ResourceOrigin for Hotfix of same template)-><resourceOriginHotfixResult>[true]->(Compare contents of template)-><templateComparisonResult>[false]->(Fail and log)->(end),<resourceOriginHotfixResult>[false]->(Migrate template)->(end),<enabledResult>[false]->(end)

Previous version:

(start)->(check autoImport property of template)-><autoImportResult>[true]->(check ResourceOrigin for same template)-><resourceOriginResult>[true]->(Delete template),<resourceOriginResult>[false]->(Migrate template),<autoImportResult>[false]->(check ResourceOrigin for Hotfix of same template)-><resourceOriginHotfixResult>[true]->(Compare contents of template)-><templateComparisonResult>[false]->(Fail and log),<templateComparisonResult>[true]->(Delete template),<resourceOriginHotfixResult>[false]->(Migrate template)->(Migrate version)->(end)

The migration process (without comparison)

This solution is kept here simply for the sake of completeness.

(start)->(check autoImport property of template)-><autoImportResult>[true]->(check ResourceOrigin for same template)-><resourceOriginResult>[true]->(Delete template),<resourceOriginResult>[false]->(Migrate template),<autoImportResult>[false]->(check ResourceOrigin for Hotfix of same template)-><resourceOriginHotfixResult>[true]->(Fail and log),<resourceOriginHotfixResult>[false]->(Migrate template)->(Migrate version)->(end)

The actual migration

  • Node-type is mgnl:content in both cases
  • Migrate text property as is
    • (text resource in resource WS have exactly the same)
  • We do not migrate enabled property
  • Migrate templateNodeName + ".ftl" as NEW resource nodename
    • Read extension from configured info.magnolia.module.inplacetemplating.JcrRepoTemplateLoader ?
      • obsolete, already removed as of 5.4, replaced by info.magnolia.freemarker.loaders.ResourceTemplateLoader
    • Official ext is ftl; fm used to be option

Additional required tasks

  • Document "non-standard" use cases
    • Observation / versionOnSave (no replacement in resources afaik)
  • JcrResourceOrigin should show "bypassed" and non-"enabled" resources & templates
    • while servlet should continue to skip them

 

 

 

  • No labels